Skip to content

fix: use child_process module to create project #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Aug 8, 2024

Description

The following error will occur on Windows platform when executing pnpm snapshot.

QQ_1723075297659

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should change this. zx is explicit about having to use bash even on Windows (see https://google.github.io/zx/setup#bash).

@btea
Copy link
Collaborator Author

btea commented Aug 8, 2024

Yeah, I noticed this too. However, the default terminal launched by vscode is not bash, and it needs to be switched manually, which seems a bit troublesome. Or, is there any other way to use bash to run files by default? 🤔

@cexbrayat
Copy link
Member

@btea I don't know how you can switch on VS Code, but I guess there is a way to define your default terminal. Let's close then

@cexbrayat cexbrayat closed this Aug 9, 2024
@btea btea deleted the fix/use-execSync branch August 10, 2024 05:50
@btea
Copy link
Collaborator Author

btea commented Aug 10, 2024

I found that we use npm-run-all2, but I think we can directly replace it with pnpm run build && pnpm run snapshot, maybe we can remove this dependency. What do you think? @cexbrayat

"pretest": "run-s build snapshot",

@cexbrayat
Copy link
Member

@btea Sure, why not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants