Skip to content

Conversation

antony-k1208
Copy link
Contributor

@antony-k1208 antony-k1208 commented Apr 15, 2024

Thanks again!

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit f6af904
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/66d985acd5a94100082301b8
😎 Deploy Preview https://deploy-preview-2798--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antony-k1208 antony-k1208 marked this pull request as ready for review August 29, 2024 12:59
@bencodezen bencodezen requested a review from yyx990803 August 30, 2024 16:37
@bencodezen bencodezen added the core-team Issues / PRs that require core team attention label Aug 30, 2024
@yyx990803
Copy link
Member

I can't see the banner in the preview - did you enable the banner component in theme/index.ts?

@antony-k1208
Copy link
Contributor Author

I can't see the banner in the preview - did you enable the banner component in theme/index.ts?

Yea wasn't careful enough with the last merge. It should be visible again now.

@yyx990803 yyx990803 merged commit 17bd491 into vuejs:main Sep 16, 2024
4 checks passed
yyx990803 added a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-team Issues / PRs that require core team attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants