Skip to content

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Aug 30, 2024

resolves #2526 proposal

@FloEdelmann FloEdelmann mentioned this pull request Aug 30, 2024
@waynzh waynzh requested a review from FloEdelmann August 30, 2024 09:03
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi August 30, 2024 09:23
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I have a change request.

@waynzh waynzh requested a review from ota-meshi September 11, 2024 07:36
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!!

@ota-meshi ota-meshi merged commit dfdbe1a into vuejs:master Sep 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule Proposal: vue/no-deprecated-delete-set

3 participants