Skip to content

Add suggestions to no-unused-vars tests on ESLint v9.17.0+ #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add suggestions to no-unused-vars tests on ESLint v9.17.0+ #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions tests/lib/rules/jsx-uses-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
*/
'use strict'

const eslint = require('../../eslint-compat')
const semver = require('semver')
const { RuleTester, ESLint } = require('../../eslint-compat')
const rule = require('../../../lib/rules/jsx-uses-vars')
const { getCoreRule } = require('../../../lib/utils')
const ruleNoUnusedVars = getCoreRule('no-unused-vars')

const RuleTester = eslint.RuleTester
const ruleTester = new RuleTester({
languageOptions: {
ecmaVersion: 6,
Expand Down Expand Up @@ -108,7 +108,23 @@ describe('jsx-uses-vars', () => {
`,
errors: [
{
message: "'SomeComponent' is defined but never used."
message: "'SomeComponent' is defined but never used.",
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
/* eslint vue/jsx-uses-vars: 1 */
import './SomeComponent.jsx';
export default {
render () {
return <div></div>;
},
};
`
}
]
: undefined
}
]
},
Expand All @@ -128,7 +144,24 @@ describe('jsx-uses-vars', () => {
`,
errors: [
{
message: "'wrapper' is assigned a value but never used."
message: "'wrapper' is assigned a value but never used.",
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
/* eslint vue/jsx-uses-vars: 1 */
import SomeComponent from './SomeComponent.jsx';
\n
export default {
render () {
return <div></div>;
},
};
`
}
]
: undefined
}
]
}
Expand Down
84 changes: 78 additions & 6 deletions tests/lib/rules/script-setup-uses-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
*/
'use strict'

const eslint = require('../../eslint-compat')
const semver = require('semver')
const { RuleTester, ESLint } = require('../../eslint-compat')
const rule = require('../../../lib/rules/script-setup-uses-vars')
const { getCoreRule } = require('../../../lib/utils')
const ruleNoUnusedVars = getCoreRule('no-unused-vars')

const RuleTester = eslint.RuleTester
const ruleTester = new RuleTester({
languageOptions: {
parser: require('vue-eslint-parser'),
Expand Down Expand Up @@ -260,7 +260,39 @@ describe('script-setup-uses-vars', () => {
errors: [
{
message: "'Bar' is defined but never used.",
line: 6
line: 6,
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
<script setup>
/* eslint vue/script-setup-uses-vars: 1 */
// imported components are also directly usable in template
import Foo from './Foo.vue'
import './Bar.vue'
import { ref } from 'vue'

// write Composition API code just like in a normal setup()
// but no need to manually return everything
const count = ref(0)
const inc = () => {
count.value++
}
const foo = ref(42)
console.log(foo.value)
const bar = ref(42)
bar.value++
const baz = ref(42)
</script>

<template>
<Foo :count="count" @click="inc" />
</template>
`
}
]
: undefined
},
{
message: "'baz' is assigned a value but never used.",
Expand All @@ -285,7 +317,24 @@ describe('script-setup-uses-vars', () => {
errors: [
{
message: "'camelCase' is defined but never used.",
line: 4
line: 4,
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
<script setup>
/* eslint vue/script-setup-uses-vars: 1 */
import './component.vue'
</script>

<template>
<CamelCase />
</template>
`
}
]
: undefined
}
]
},
Expand All @@ -308,7 +357,25 @@ describe('script-setup-uses-vars', () => {
errors: [
{
message: "'msg' is assigned a value but never used.",
line: 5
line: 5,
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
<script setup>
/* eslint vue/script-setup-uses-vars: 1 */
if (a) {
\n }
</script>

<template>
<div>{{ msg }}</div>
</template>
`
}
]
: undefined
}
]
},
Expand Down Expand Up @@ -372,7 +439,12 @@ describe('script-setup-uses-vars', () => {
// v-bind(color)
</style>
`,
errors: ["'color' is assigned a value but never used."]
errors: [
{
message: "'color' is assigned a value but never used.",
line: 4
}
]
}
]
})
Expand Down
73 changes: 69 additions & 4 deletions tests/lib/script-setup-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict'

const { RuleTester } = require('../eslint-compat')
const semver = require('semver')
const { RuleTester, ESLint } = require('../eslint-compat')
const { getCoreRule } = require('../../lib/utils')
const ruleNoUnusedVars = getCoreRule('no-unused-vars')
const ruleNoUndef = getCoreRule('no-undef')
Expand Down Expand Up @@ -220,7 +221,38 @@ describe('vue-eslint-parser should properly mark the variables used in the templ
errors: [
{
message: "'Bar' is defined but never used.",
line: 5
line: 5,
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
<script setup>
// imported components are also directly usable in template
import Foo from './Foo.vue'
import './Bar.vue'
import { ref } from 'vue'

// write Composition API code just like in a normal setup()
// but no need to manually return everything
const count = ref(0)
const inc = () => {
count.value++
}
const foo = ref(42)
console.log(foo.value)
const bar = ref(42)
bar.value++
const baz = ref(42)
</script>

<template>
<Foo :count="count" @click="inc" />
</template>
`
}
]
: undefined
},
{
message: "'baz' is assigned a value but never used.",
Expand All @@ -244,7 +276,23 @@ describe('vue-eslint-parser should properly mark the variables used in the templ
errors: [
{
message: "'camelCase' is defined but never used.",
line: 3
line: 3,
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
<script setup>
import './component.vue'
</script>

<template>
<CamelCase />
</template>
`
}
]
: undefined
}
]
},
Expand All @@ -266,7 +314,24 @@ describe('vue-eslint-parser should properly mark the variables used in the templ
errors: [
{
message: "'msg' is assigned a value but never used.",
line: 4
line: 4,
suggestions: semver.gte(ESLint.version, '9.17.0')
? [
{
messageId: 'removeVar',
output: `
<script setup>
if (a) {
\n }
</script>

<template>
<div>{{ msg }}</div>
</template>
`
}
]
: undefined
}
]
},
Expand Down
Loading