Skip to content

Move unused ESLint config for internal rules to main ESLint config #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Move unused ESLint config for internal rules to main ESLint config #2664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions eslint-internal-rules/.eslintrc.json
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
// turn off some rules from shared configs in all files
{
rules: {
'eslint-plugin/require-meta-default-options': 'off', // TODO: enable when all rules have defaultOptions

Check warning on line 48 in eslint.config.js

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected 'todo' comment: 'TODO: enable when all rules have...'
'eslint-plugin/require-meta-docs-recommended': 'off', // use `categories` instead
'eslint-plugin/require-meta-schema-description': 'off',

Expand Down Expand Up @@ -231,7 +231,9 @@
{
files: ['eslint-internal-rules/*.js'],
rules: {
'eslint-plugin/require-meta-docs-url': 'off'
'eslint-plugin/require-meta-docs-url': 'off',
'internal/no-invalid-meta': 'error',
'internal/no-invalid-meta-docs-categories': 'error'
}
},
{
Expand Down
Loading