Skip to content

fix: fix walking program AST when multiple script blocks #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix: fix walking program AST when multiple script blocks #2703

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb875e
fix: fix walking script setup ast when multiple script blocks
ntnyq Mar 5, 2025
254e6f7
test: add more test cases
ntnyq Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,7 +1380,7 @@ module.exports = {
* @param {any[]} args
*/
function callVisitor(key, node, ...args) {
if (visitor[key] && inScriptSetup(node)) {
if (visitor[key] && (node.type === 'Program' || inScriptSetup(node))) {
// @ts-expect-error
visitor[key](node, ...args)
}
Expand Down
44 changes: 44 additions & 0 deletions tests/lib/rules/prefer-use-template-ref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,23 @@ tester.run('prefer-use-template-ref', rule, {
})
</script>
`
},
{
filename: 'multiple-scripts.vue',
code: `
<template>
<div ref="root" :data-a="A" />
</template>

<script>
const A = 'foo'
</script>

<script setup>
import { useTemplateRef } from 'vue'
const root = useTemplateRef('root')
</script>
`
}
],
invalid: [
Expand Down Expand Up @@ -420,6 +437,33 @@ tester.run('prefer-use-template-ref', rule, {
column: 28
}
]
},
{
filename: 'multiple-scripts.vue',
code: `
<template>
<div ref="root" :data-a="A" />
</template>

<script>
const A = 'foo'
</script>

<script setup>
import { ref } from 'vue'
const root = ref()
</script>
`,
errors: [
{
messageId: 'preferUseTemplateRef',
data: {
name: 'ref'
},
line: 12,
column: 20
}
]
}
]
})
Loading