Skip to content

fix: fix typecheck #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

fix: fix typecheck #2707

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0db9b7
fix: fix typecheck
ntnyq Mar 6, 2025
b7e5f1d
Make condition more consistent and easy to read
FloEdelmann Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/no-duplicate-attr-inheritance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ module.exports = {
const options = context.options[0] || {}
const checkMultiRootNodes = options.checkMultiRootNodes === true

/** @type {string | number | boolean | RegExp | BigInt | null} */
/** @type {Literal['value']} */
let inheritsAttrs = true
/** @type {VReference[]} */
const attrsRefs = []
Expand Down
7 changes: 5 additions & 2 deletions lib/rules/no-unused-refs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,11 @@ module.exports = {
CallExpression(callExpression) {
const firstArgument = callExpression.arguments[0]
if (
callExpression.callee.name !== 'useTemplateRef' ||
!firstArgument
('name' in callExpression.callee &&
callExpression.callee.name !== 'useTemplateRef') ||
!firstArgument ||
(firstArgument.type !== 'Literal' &&
firstArgument.type !== 'TemplateLiteral')
) {
return
}
Expand Down
Loading