Skip to content

Conversation

@9romise
Copy link
Contributor

@9romise 9romise commented Nov 22, 2025

Move configs and plugins to separate modules, avoid circular dependencies. This can help resolve test errors in #2916.

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2025

⚠️ No Changeset found

Latest commit: 0d49b24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@9romise 9romise changed the title refactor: split configs and plugin to resolve circular dependencies refactor: split configs and plugin to separate modules Nov 22, 2025
9romise added a commit to 9romise/eslint-plugin-vue that referenced this pull request Nov 22, 2025
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you! 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the plugin architecture by splitting configs and plugin into separate modules to avoid circular dependencies and resolve test errors.

Key Changes:

  • Created lib/plugin.js containing rules and processors (auto-generated)
  • Created lib/configs/index.js to centralize all config exports
  • Updated lib/index.js to combine plugin and configs modules
  • Updated flat config files to reference ../../plugin instead of ../../index
  • Replaced tools/update-lib-index.js with tools/update-lib-plugin.js

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/update.js Updated to require the new update-lib-plugin script instead of update-lib-index
tools/update-lib-plugin.js New script that generates lib/plugin.js with rules and processors
tools/update-lib-index.js Removed - replaced by separate plugin and configs modules
tools/update-lib-flat-configs.js Updated to reference ../../plugin instead of ../../index in generated flat configs
lib/plugin.js New auto-generated file containing plugin meta, rules, and processors
lib/index.js Refactored to import and combine separate configs and plugin modules
lib/configs/index.js New file that centralizes all config exports (eslintrc, flat, and no-layout-rules)
lib/configs/flat/base.js Updated to require ../../plugin instead of ../../index to avoid circular dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants