-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
build: reinstate ESM browser builds #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vue-router canceled.
|
WalkthroughAdded two new build configurations, esmBrowser and esmBrowserProd, derived from esm, adjusting output filenames, dev flags, and minification. Updated the default export array to include these configurations alongside existing esm, cjs, and iife builds. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 46 46
Lines 4179 4179
Branches 1111 1111
=======================================
Hits 3804 3804
Misses 368 368
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
vue-router.esm-browser.js
andvue-router.esm-browser.prod.js
are missing from Vue Router 4.6.0. This PR brings them back.These files are used when importing directly from a CDN.
It is possible to use
vue-router.mjs
directly in the browser, but it requires polyfills.vue-router.esm-browser.js
removes references toprocess.env
and__VUE_PROD_DEVTOOLS__
, so it can be used without those polyfills.vue-router.esm-browser.prod.js
has dev-only code removed, is minified, and has no dependency on@vue/devtools-api
.See also #2569 (comment).
Summary by CodeRabbit