-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(unplugin): Avoid generating empty routes #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FrontEndDog
wants to merge
9
commits into
vuejs:main
Choose a base branch
from
FrontEndDog:fix/empty-routes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−2
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
646bbf5
fix(unplugin): Avoid generating empty routes
FrontEndDog a07b7fe
fix(generateRouteRecords): remove lone children nodes from route records
FrontEndDog 9dcdf60
fix(generateRouteRecords): skip nested lone _parent files in route ge…
FrontEndDog 0f610c3
fix(generateRouteRecords): correct comment to reflect deletion of lon…
FrontEndDog e41658f
fix(generateRouteRecords): skip deletion of lone parent nodes in rout…
FrontEndDog c4e2148
fix(TreeNode): prevent deletion of root nodes without children in rou…
FrontEndDog 4f9708a
fix(tree): add test for removing parent when last child of non-matcha…
FrontEndDog 665ce2e
fix(tree): remove unnecessary insertion of parent node in test case
FrontEndDog 2505de9
fix(tree): add test for removing parent when last child of a non-matc…
FrontEndDog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this test verifies that route generation correctly skips nested lone _parent files, it doesn't test the dynamic deletion scenario that the bug fix addresses. Consider adding a test in tree.spec.ts that inserts a parent node with children, then deletes the children (using node.delete()), and verifies that the parent node is also removed. This would directly test the recursive cleanup logic added to the delete() method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for you review, done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, my comment wasn't clear: you don't necessarily need to remove your test, it's great to have an e2e test like that but it still need the deletion part to get closer to the scenario you were describing with a deletion. IIRC there are EditableTree tests, which should feel closer to your actual scenario