fix(matcher): finalize param token before processing escaped colon#2654
fix(matcher): finalize param token before processing escaped colon#2654babu-ch wants to merge 2 commits intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-router canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR fixes a bug where route parameters followed by escaped colons were incorrectly parsed, causing parameter names to have colon suffixes and values to have colon prefixes. Changes include a tokenizer update to handle escape sequences properly, comprehensive test coverage for escaped colon scenarios, and playground examples demonstrating the fix. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
==========================================
+ Coverage 85.66% 85.67% +0.01%
==========================================
Files 86 86
Lines 10007 10015 +8
Branches 2289 2291 +2
==========================================
+ Hits 8572 8580 +8
Misses 1422 1422
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixes #2517
Summary by CodeRabbit
New Features
Tests