Skip to content

fix(query): use Object.create(null) to prevent prototype pollution #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wdskuki wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(query): use Object.create(null) to prevent prototype pollution #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/router/src/location.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function parseURL(
currentLocation: string = '/'
): LocationNormalized {
let path: string | undefined,
query: LocationQuery = {},
query: LocationQuery = Object.create(null),
searchString = '',
hash = ''

Expand Down
4 changes: 2 additions & 2 deletions packages/router/src/query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export type LocationQueryRaw = Record<
* @returns a query object
*/
export function parseQuery(search: string): LocationQuery {
const query: LocationQuery = {}
const query: LocationQuery = Object.create(null)
// avoid creating an object with an empty key and empty value
// because of split('&')
if (search === '' || search === '?') return query
Expand Down Expand Up @@ -131,7 +131,7 @@ export function stringifyQuery(query: LocationQueryRaw | undefined): string {
export function normalizeQuery(
query: LocationQueryRaw | undefined
): LocationQuery {
const normalizedQuery: LocationQuery = {}
const normalizedQuery: LocationQuery = Object.create(null)

for (const key in query) {
const value = query[key]
Expand Down