feat!: enable noUncheckedIndexedAccess and exactOptionalPropertyTypes
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://www.semver-ts.org/formal-spec/5-compiler-considerations.html#strictness for the arguments for turning on noUncheckedIndexedAccess for libraries. In short, it helps prevent shipping accidental breaking type changes to library consumers. (Note the link also suggests turning on `exactOptionalPropertyTypes`, but I still have doubts about it, as it would not be helpful without a specific coding style, which is hard to enforce.)
|
Update: both |
…pes` As recommended in TS 5.9: microsoft/TypeScript#61813
haoqunjiang
changed the title
noUncheckedIndexedAccess and exactOptionalPropertyTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.semver-ts.org/formal-spec/5-compiler-considerations.html#strictness for the arguments for turning on noUncheckedIndexedAccess for libraries.
In short, it helps prevent shipping accidental breaking type changes to library consumers.
The link also suggests turning on
exactOptionalPropertyTypes, but I still have doubts about it, as it would not be helpful without a specific coding style, which is hard to enforce. By moving both options to the baselinetsconfig.json, we can ensure strictness across the ecosystem.