Skip to content

fix(theme): strip system-ui from font-family-base #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(theme): strip system-ui from font-family-base #4988

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b2c6d9
fix(theme): strip system-ui from font-family-base
tats-u Oct 14, 2025
f99f3cf
Exclude ambiguous punctuation from Inter in CJK languages
tats-u Oct 15, 2025
7056a99
Do not apply custom Inter to Korean
tats-u Oct 15, 2025
31d7db2
Fix comment
tats-u Oct 15, 2025
9c5a51e
Enable kana kerning & auto phrase in Japanese hero text
tats-u Oct 16, 2025
256340b
Enable text-autospace and line-break: strict for CJK languages
tats-u Oct 16, 2025
6949d30
Reduce specificity
tats-u Oct 17, 2025
ee9a64a
Defer text-autospace to another PR
tats-u Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/client/theme-default/styles/vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,20 +262,14 @@

:root {
--vp-font-family-base:
'Inter', ui-sans-serif, system-ui, sans-serif, 'Apple Color Emoji',
'Inter', -apple-system, BlinkMacSystemFont, sans-serif, 'Apple Color Emoji',
'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';
--vp-font-family-mono:
ui-monospace, 'Menlo', 'Monaco', 'Consolas', 'Liberation Mono',
'Courier New', monospace;
font-optical-sizing: auto;
}

:root:where(:lang(zh)) {
--vp-font-family-base:
'Punctuation SC', 'Inter', ui-sans-serif, system-ui, sans-serif,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed? I think it's still needed because otherwise the punctuation will use Inter instead of Chinese font. 👀

Copy link
Author

@tats-u tats-u Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the punctuation will use Inter instead of Chinese font

Do you know which characters/code points are affected? I think it also occurs in Japanese and they should be removed from Inter if possible.
I suppose it is better to respect sans-serif there instead of using a custom font.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible candidates:

“
”
‘
’
…
—

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these -

vitepress/src/client/theme-default/styles/fonts.css

Lines 157 to 159 in 7658ad3

unicode-range:
U+201C, U+201D, U+2018, U+2019, U+2E3A, U+2014, U+2013, U+2026, U+00B7,
U+007E, U+002F;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the range of Inter is also defined by us. Let's add a new @font-face variant for CJK languages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the following references:

https://www.unicode.org/L2/L2014/14006-sv-western-vs-cjk.pdf
https://www.unicode.org/L2/L2018/18013-svs-proposal.pdf
https://www.unicode.org/L2/L2018/18073-svs-proposal.pdf
https://www.unicode.org/L2/L2023/23212r-quotes-svs-proposal.pdf

Copy link
Author

@tats-u tats-u Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U+007E, U+002F

Do you know why they were added? I think they should be dedicated to zh(-Hans) if they remain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had copied it from https://github.com/w3c/clreq/blob/f837ffe4a5501e72c17bd02961ce1b440916624f/local.css#L4 😅

Copy link
Author

@tats-u tats-u Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's the great clreq. It claims that it also covers traditional Chinese. I will follow it in both simplified and traditional Chinese.

'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';
}

/**
* Shadows
* -------------------------------------------------------------------------- */
Expand Down