feat(core): add userStyle option to ensure highest priority, closes #1110

[Mister-Hope]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 23324886226

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.05%) to 75.086%

---

Totals
Change from base Build 23282024048:	-0.05%
Covered Lines:	736
Relevant Lines:	980

---

💛 - Coveralls

[Copilot]

Pull request overview

Adds a userStyle theme option intended to inject a user-provided style file late in the client entry, so it has higher CSS precedence in the final bundle.

Changes:

• Extend core types (ThemeObject, ThemeInfo, App) with an optional userStyle string.
• Resolve userStyle through theme inheritance and attach it to the app instance.
• Inject userStyle as an additional import in the generated @internal/clientConfigs temp module.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/core/src/types/theme.ts	Adds userStyle?: string to theme typing and resolved theme info typing.
packages/core/src/types/app/app.ts	Adds userStyle?: string onto the App type surface.
packages/core/src/app/setupAppThemeAndPlugins.ts	Copies resolved themeInfo.userStyle onto app.userStyle.
packages/core/src/app/resolveThemeInfo.ts	Attempts to merge userStyle through theme inheritance.
packages/core/src/app/prepare/prepareClientConfigs.ts	Adds an import for app.userStyle in the generated client configs entry.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

resolveThemeInfo() never includes userStyle in the base themeInfo object, so themes that do not extend a parent theme will always end up with app.userStyle as undefined even if themeObject.userStyle is set. Include userStyle: themeObject.userStyle in the initial themeInfo (and/or ensure the non-extends branch returns it).

[Copilot]

The new userStyle resolution logic should be covered by unit tests (there are already tests for resolveThemeInfo). Add cases asserting userStyle is returned for a theme with no parent, and that child themes correctly override / inherit userStyle from parents.

[Copilot]

app.userStyle is interpolated directly into a JS import string literal. If the path contains backslashes (Windows), quotes, or other escapable characters, it can produce invalid generated code. Prefer using JSON.stringify(app.userStyle) (and ideally the same for clientConfigFiles) when generating import specifiers so they are safely escaped.

Suggested change

	(filePath, index) => `import * as clientConfig${index} from '${filePath}'`,
	)
	.join('\n')}
	${app.userStyle ? `\nimport '${app.userStyle}'` : ''}
	(filePath, index) => `import * as clientConfig${index} from ${JSON.stringify(filePath)}`,
	)
	.join('\n')}
	${app.userStyle ? `\nimport ${JSON.stringify(app.userStyle)}` : ''}

[Copilot]

userStyle is assigned during app creation (setupAppThemeAndPlugins() is called from createDevApp/createBuildApp before app.init()), so placing it under AppPropertiesInitialized and documenting it as only available after initialization is misleading. Consider moving userStyle to AppPropertiesBase, or adjust the initialization flow/docs so it truly becomes available only after init().