feat: add stripe payment element support#257
Open
mdavo6 wants to merge 7 commits intovuestorefront-community:mainfrom
Open
feat: add stripe payment element support#257mdavo6 wants to merge 7 commits intovuestorefront-community:mainfrom
mdavo6 wants to merge 7 commits intovuestorefront-community:mainfrom
Conversation
letelete
reviewed
Aug 22, 2022
Contributor
Author
|
Thanks for the review @letelete . I have updated to address your feedback if you would like to take another look 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
addPaymentMethodandgetPaymentIntent.Related Issue
#256
Motivation and Context
See description in #256
In short, the Stripe payment element offers 18+ payment methods OOB vs the current implementation which offers card payment only.
How Has This Been Tested?
Tested on chrome. Note: PR will require corresponding spree_gateway PR to work spree-contrib/spree_gateway#409.
Screenshots (if appropriate):
Types of changes
Checklist: