fix: mark placeholder option as selected in react SfSelect (#3263)#3265
Merged
Szymon-dziewonski merged 3 commits intov2from Jan 20, 2025
Merged
fix: mark placeholder option as selected in react SfSelect (#3263)#3265Szymon-dziewonski merged 3 commits intov2from
Szymon-dziewonski merged 3 commits intov2from
Conversation
* fix: mark placeholder option as selected in react SfSelect * chore: changeset * refactor: add internal value to vue SfSelect * chore: changeset for vue * refactor: remove redundant <script setup /> from vue components * refactor: internal state in SfSelect * refactor: remove disabled and selected attributes * chore: remove disabled in vue placeholder option * Revert "refactor: remove redundant <script setup /> from vue components" This reverts commit dafb778. * refactor: set inheritAttrs through defineOptions
Szymon-dziewonski
requested review from
FRSgit,
filrak and
mattmaribojoc
as code owners
|
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
Szymon-dziewonski
temporarily deployed
to
stage
GitHub Actions
Inactive
FRSgit
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #
Scope of work
Screenshots of visual changes
Checklist