Merged
Conversation
* fix: changed paddings in sfselect * chore: adjusted padding left * chore: updated changelog * Update .changeset/fresh-emus-care.md Co-authored-by: Jakub Freisler <jakub@frsource.org> --------- Co-authored-by: Jakub Freisler <jakub@frsource.org>
* BREAKING CHANGE: remove flex classes form wrapper slot in list item * fix: lint fixes * fix: lint fixes
#3008) BREAKING CHANGE: remove deprecated useTrapFocus arrowKeysOn option
🦋 Changeset detectedLatest commit: 258f8b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
looking forward to use it with tailwind v4 |
1 task
# Conflicts: # apps/docs/components/content/_hooks/useTrapFocus.md # packages/sfui/frameworks/react/components/SfListItem/SfListItem.tsx # packages/sfui/frameworks/vue/components/SfListItem/SfListItem.vue # packages/sfui/frameworks/vue/composables/useTrapFocus/useTrapFocus.ts # packages/tests/components/SfButton/SfButton.cy.tsx
# Conflicts: # apps/docs/components/components/content/ColorPaletteBlock.vue # apps/preview/next/package.json # apps/preview/next/pages/examples/SfAccordionItem.tsx # apps/preview/next/pages/showcases/ProductCard/Details.tsx # apps/preview/next/pages/showcases/ProductCard/ProductCardHorizontal.tsx # apps/preview/next/pages/showcases/QuantitySelector/OutOfStock.tsx # apps/preview/next/pages/showcases/QuantitySelector/QuantitySelector.tsx # apps/preview/next/pages/showcases/QuantitySelector/Rounded.tsx # apps/preview/nuxt/pages/examples/SfAccordionItem.vue # apps/test/react/package.json # apps/test/vue/package.json # package.json # packages/config/tailwind/index.ts # packages/config/tailwind/package.json # packages/sfui/frameworks/react/components/SfButton/SfButton.tsx # packages/sfui/frameworks/react/components/SfCheckbox/SfCheckbox.tsx # packages/sfui/frameworks/react/components/SfChip/SfChip.tsx # packages/sfui/frameworks/react/components/SfInput/SfInput.tsx # packages/sfui/frameworks/react/components/SfLink/SfLink.tsx # packages/sfui/frameworks/react/components/SfModal/SfModal.tsx # packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx # packages/sfui/frameworks/react/components/SfTextarea/SfTextarea.tsx # packages/sfui/frameworks/vue/components/SfAccordionItem/SfAccordionItem.vue # packages/sfui/frameworks/vue/components/SfButton/SfButton.vue # packages/sfui/frameworks/vue/components/SfCheckbox/SfCheckbox.vue # packages/sfui/frameworks/vue/components/SfChip/SfChip.vue # packages/sfui/frameworks/vue/components/SfInput/SfInput.vue # packages/sfui/frameworks/vue/components/SfLink/SfLink.vue # packages/sfui/frameworks/vue/components/SfModal/SfModal.vue # packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue # packages/sfui/frameworks/vue/components/SfTextarea/SfTextarea.vue # yarn.lock
patch sf-docs-base to handle new tailwind
215ac83 to
89effc8
Compare
89effc8 to
d9f00e7
Compare
Contributor
Szymon-dziewonski
left a comment
There was a problem hiding this comment.
Titanic work, great PR!
I approved in advance, and leave only couple of questions !
Szymon-dziewonski
approved these changes
Oct 24, 2025
ddd2abc to
beda435
Compare
beda435 to
6f28f8e
Compare
…refront/storefront-ui into feat/tailwind-4-migration
|
Hi @FRSgit ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #
Scope of work
https://tailwindcss.com/docs/upgrade-guide
To avoid some of the breaking changes introduced by Tailwind 4 and to keep sensible defaults we want to give to out users, SFUI Tailwind configuration:
cursor: pointerstyle for button elements.Screenshots of visual changes
Checklist