-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: new component tabs #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
Fix inverted condition in TabsPanel that prevented proper ticket lookup by value. The condition checked for empty results (=== 0) when it should check for matches (> 0), causing panels to receive incorrect IDs and breaking aria-controls/aria-labelledby relationships with their corresponding tabs. Fixes tests: - "should have correct ARIA attributes" - "should match aria-controls and aria-labelledby" Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove unsafe type assertion in TabsPanel ticket lookup - Change onBeforeUnmount to onUnmounted for consistency with Radio - Add template ref for focus management instead of DOM queries - Add TabsTicket interface with el property for focus tracking - Add edge case tests: empty/single tabs, all-disabled, dynamic lifecycle - Add loop=false boundary behavior tests
1691d65 to
0275456
Compare
- Rename TabsTab.vue to TabsItem.vue and update all exports/types - Add inheritAttrs: false and useAttrs() pattern to TabsList, TabsItem, TabsPanel - Add aria-label, aria-labelledby, aria-describedby props to TabsItem - Add data-disabled attribute to TabsList - Remove redundant Readonly wrappers from TabsContext interface - Add documentation page and basic example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.