Skip to content

fix(VDialog): focus trap should ignore invisible and inert elements #22105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Draft

fix(VDialog): focus trap should ignore invisible and inert elements #22105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c5681b
fix(VDialog): focus trap should ignore invisible and inert elements
J-Sek Sep 22, 2025
e13bd0b
Include `inert` children
J-Sek Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/vuetify/src/util/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,11 +650,16 @@ export function callEvent<T extends any[]> (handler: EventProp<T> | EventProp<T>
}
}

function isRendered (el: HTMLElement) {
return !!el.offsetParent || el.getClientRects().length > 0
}

export function focusableChildren (el: Element, filterByTabIndex = true) {
const targets = ['button', '[href]', 'input:not([type="hidden"])', 'select', 'textarea', '[tabindex]']
.map(s => `${s}${filterByTabIndex ? ':not([tabindex="-1"])' : ''}:not([disabled])`)
.map(s => `${s}${filterByTabIndex ? ':not([tabindex="-1"])' : ''}:not([disabled]):not(:is([inert] *))`)
.join(', ')
return [...el.querySelectorAll(targets)] as HTMLElement[]
return ([...el.querySelectorAll(targets)] as HTMLElement[])
.filter(isRendered)
}

export function getNextElement (elements: HTMLElement[], location?: 'next' | 'prev', condition?: (el: HTMLElement) => boolean) {
Expand Down