Skip to content

fix(VTimePicker): separator size based on density #22136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+19 −2
Open

fix(VTimePicker): separator size based on density #22136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14b53b1
fix: change separator size based on density
Haviles04 Sep 30, 2025
8819beb
Merge branch 'master' into haviles04/fix-v-time-picker-separator-density
Haviles04 Sep 30, 2025
d98eeb6
Merge branch 'master' into haviles04/fix-v-time-picker-separator-density
Haviles04 Oct 1, 2025
8c4115d
Merge branch 'master' into haviles04/fix-v-time-picker-separator-density
Haviles04 Oct 1, 2025
7b6c158
tweaks: align height + bold to make it visible
J-Sek Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/vuetify/src/components/VTimePicker/VTimePickerControls.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@
height: $time-picker-controls-seconds-btn-height
font-size: $time-picker-controls-btn-font

&--density-compact
.v-time-picker-controls__time__separator
font-size: 16px
font-weight: bold
height: 24px

&--density-comfortable
.v-time-picker-controls__time__separator
font-size: 18px
font-weight: bold
height: 28px

.v-time-picker-controls__ampm
margin-left: 12px
align-self: flex-end
Expand Down
9 changes: 7 additions & 2 deletions packages/vuetify/src/components/VTimePicker/VTimePickerControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { pad } from './util'
import { VBtn } from '@/components/VBtn'

// Composables
import { makeDensityProps, useDensity } from '@/composables/density'
import { useLocale } from '@/composables/locale'

// Utilities
Expand All @@ -28,6 +29,7 @@ export const makeVTimePickerControlsProps = propsFactory({
useSeconds: Boolean,
value: Number,
viewMode: String as PropType<VTimePickerViewMode>,
...makeDensityProps(),
}, 'VTimePickerControls')

export const VTimePickerControls = genericComponent()({
Expand All @@ -42,6 +44,7 @@ export const VTimePickerControls = genericComponent()({

setup (props, { emit, slots }) {
const { t } = useLocale()
const { densityClasses } = useDensity(props)

useRender(() => {
let hour = props.hour
Expand All @@ -51,10 +54,12 @@ export const VTimePickerControls = genericComponent()({
return (
<div class="v-time-picker-controls">
<div
class={{
class={[{
'v-time-picker-controls__time': true,
'v-time-picker-controls__time--with-seconds': props.useSeconds,
}}
},
densityClasses.value,
]}
>
<VBtn
active={ props.viewMode === 'hour' }
Expand Down