docs: New Sponsor Popup #22393
Draft
docs: New Sponsor Popup #22393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Popups are yucky 🤢 |
Contributor
|
Minor UI improvements + reordered links. I don't mind experimenting with new placement. Those "ads via vuetify" do not show up on Brave. Preview
|
Contributor
Author
|
The idea was to mimic the lil popup that coolify has |
Member
Most of them are adblocked though. |
Member
|
uBlock doesn't block them, only 5% of our traffic uses brave. What makes you think brave won't block this too? |
Member
|
If you're going to add this anyway the dismiss button needs to be remembered, and it probably shouldn't appear until either navigation or focus loss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New sponsorship popup