[VUFIND-1674] Show count of saved items in account menu#3836
[VUFIND-1674] Show count of saved items in account menu#3836demiankatz wants to merge 6 commits intovufind-org:devfrom
Conversation
| public function handleRequest(Params $params) | ||
| { | ||
| $this->disableSessionWrites(); // avoid session write timing bug | ||
| $count = $this->user ? count($this->resourceService->getFavorites($this->user)) : 0; |
There was a problem hiding this comment.
Is it worth creating a new resourceService method that just returns a count to reduce the amount of data pushed around, or is it better to keep this simple and trust the caching?
| <?php endforeach; ?> | ||
| </div> | ||
|
|
||
| <?php if (!isset($list)): ?> |
There was a problem hiding this comment.
Right now, the cache only gets invalidated when you go to the favorites page. Maybe it would be better to always invalidate the cache on all list pages, so that list actions cause the favorites total to get recalculated. However, this would make a lot of unnecessary requests or would require the addition of some additional logic to figure out when invalidation is really needed.
|
This needs more time to mature, so I am moving it to the 11.0 milestone. |
|
Reassigning milestone as per discussion on the 1 July Community Call. |
1 participant
This is an initial proof of concept.
TODO