Skip to content

Use div instead of br to format more of list-entry.phtml.#4890

Draft
demiankatz wants to merge 1 commit intovufind-org:devfrom
demiankatz:reduce-linebreaks-in-list-entry
Draft

Use div instead of br to format more of list-entry.phtml.#4890
demiankatz wants to merge 1 commit intovufind-org:devfrom
demiankatz:reduce-linebreaks-in-list-entry

Conversation

@demiankatz
Copy link
Member

The markup of list-entry.phtml is a bit confusing and causes excessive whitespace. This PR attempts to simplify it by using more block elements instead of hard-coded breaks.

TODO:

  • Should we put explicit classes on all of these divs to assist with styling?
  • Should we take this refactoring further?
  • We should test all of the possible permutations of included/excluded data/elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant