Refactor AbstractMenuHelper and its children classes to use constructor injection and Autowiring#5073
Open
sambhavp96 wants to merge 2 commits intovufind-org:dev-12.0from
Open
Conversation
demiankatz
requested changes
Feb 16, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
@sambhavp96, I was struggling to understand why things were working even though the factory for AdminMenu was not injecting the right dependencies -- and then I realized that AbstractMenuHelper, AccountMenu, and AdminMenu were all deprecated in release 11.1 and are no longer used at all in this branch. These three helpers (and associated factories) should simply be deleted here. Sorry for not realizing this sooner!
Is it intentional that the Context helper is also included in this PR? Would it make sense to open a separate PR to delete the deprecated files, and then repurpose this one into a Context helper modernization?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.