Remove unused, deprecated view helpers#5074
Open
sambhavp96 wants to merge 3 commits intovufind-org:dev-12.0from
Open
Remove unused, deprecated view helpers#5074sambhavp96 wants to merge 3 commits intovufind-org:dev-12.0from
sambhavp96 wants to merge 3 commits intovufind-org:dev-12.0from
Conversation
demiankatz
requested changes
Feb 16, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Please also remove AccountMenuFactory and AdminMenuFactory, and the associated theme.config.php lines.
demiankatz
requested changes
Feb 16, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @sambhavp96 -- unfortunately, running tests here reveals that one detail has been missed in the dev branch, so even though accountMenu is deprecated, it is still being used:
I will talk to @aleksip to figure out the best solution for this problem. Once it is resolved, this should be safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.