Refactor AbstractJsStrings and related classes to use constructor injection and Autowiring

[sambhavp96]

No description provided.

[demiankatz]

@sambhavp96, I'm encountering test failures because theme.config.php still has the InvokableFactory set for the TransEsc view helper, so the plugin manager is trying to build the class without its dependencies. You might want to double-check that all of the helper factory settings are removed or updated as appropriate. Once you've had a chance to do that, I'll try the tests again.

Thanks for the progress; sorry for the bumpy road! :-)

[demiankatz]

Thanks, @sambhavp96, this is looking great so far. I pushed up a small change to introduce constructor property promotion to AbstractJsStrings (since it seemed faster to make the edit than to write up a comment suggesting that you do it).

Only one more thing I would suggest to finish this up: the JsIcons view helper is the other subclass of AbstractJsStrings, but it has not yet been revised to use property promotion and autowiring. It would probably make sense to take care of that one here so that all the related work is done together. I think it will be pretty straightforward.