Refactor SearchParams and SearchTabs view helpers to use autowiring#5085
Merged
demiankatz merged 4 commits intovufind-org:dev-12.0from Feb 19, 2026
Merged
Conversation
demiankatz
requested changes
Feb 18, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @sambhavp96, looks good to me -- just one suggestion (which simply repeats an idea from my last review).
demiankatz
changed the title
demiankatz
added
the
architecture
Member
|
Since there's only one small suggested change here and you're out of time for the week, I'm going to go ahead and apply my suggestion and run tests now. |
demiankatz
approved these changes
Feb 19, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
All tests are passing -- thanks, @sambhavp96!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.