Merge in upstream & rename to vulkano-rangemap #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the sparse and dense maps are both converted to Vecs (items in dense map are coalesced by its new iterator) and compared. We'll get better messages out of test assertions this way, and it all feels a little bit neater. I've done this because I'm planning to use the dense map in more tests.
They were sometimes returning empty ranges still, and the implementation was unnecessarily complex. There may well have been other bugs hiding in there. Fixes jeffparsons#43. This also adds fuzzing of the gaps iterators to get a bit more confidence that they're actually right now, including fuzzing the size of the outer range.
Fix empty ranges returned by `Gaps` iterators
Contains more `Gaps` iterator fixes. This time with fuzz testing to gain some confidence that it's actually right this time.
An empty gap is meaningless, and an empty outer range has no values that could be considered a gap. I've also yet again slightly simplified the gaps logic to make it clearer what's going on.
Don't yield an empty gap for an empty outer range
Contains fix for an empty gap being yielded for an empty outer range.
Adds a test for `Gaps` iterator where the outer range lies within the first of two stored ranges. ``Bash ---- map::tests::_has_rangemap_v1_0_2_return_start_greater_than_end_gaps stdout ---- thread 'map::tests::_has_rangemap_v1_0_2_return_start_greater_than_end_gaps' panicked at 'assertion failed: `(left == right)` left: `Some(5..3)`, right: `None`', src/map.rs:1239:9 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` See also issue jeffparsons#47
[test] Add test case that failed on v1.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.