Conversation
…D, Registry Repos Info, Registry Region Info
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
===========================================
- Coverage 89.70% 59.24% -30.47%
===========================================
Files 33 3 -30
Lines 1010 449 -561
Branches 171 73 -98
===========================================
- Hits 906 266 -640
- Misses 45 182 +137
+ Partials 59 1 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@resmo I'm sure there are a few changes that are needed here, but I would need fresh eyes to spot them. Also, the version used in the changes was made early in the process of building this out - would |
|
@jasites reviewing is on my list, sorry for the delay. |
resmo
left a comment
There was a problem hiding this comment.
except for the verison string to be 1.14.0 IMHO, didn't see any obvious mistakes. good job.
| --- | ||
| module: container_registry_info | ||
| short_description: Get information about the Vultr container registries | ||
| version_added: "1.15.0" |
There was a problem hiding this comment.
next release would be 1.14 right?
| --- | ||
| module: container_registry_region_info | ||
| short_description: Get information about the Vultr container registry regions | ||
| version_added: "1.15.0" |
|
@resmo Thanks for the review! I want to make another pass at this, as significant enhancements and changes were made to the feature after I last worked on this. I'm not sure when I will be able to get back to this (hopefully soon!), so I would recommend releasing 1.14.0 before waiting on this one... |
|
@jasites I am preparing a 1.4.0 release, would you mind if this is not in it? |
Not at all - getting a new release out is more important. |
Description
Adds initial support for Vultr Container Registry
plan_container_registry_info)container_registry)container_registry_info)container_registry_repository)container_registry_repository_info)container_registry_region_info)The work for managing repo users was started, but while that was being done, extensive work was done to expand the options available for managing users via the API. As this was getting rather cumbersome as it is, I wanted to get this in before starting on the user management portion.
Related Issues
Resolves #107
Checklist: