Skip to content

Container Registry#134

Draft
jasites wants to merge 2 commits intovultr:mainfrom
jasites:107-feature-container-registry-support
Draft

Container Registry#134
jasites wants to merge 2 commits intovultr:mainfrom
jasites:107-feature-container-registry-support

Conversation

@jasites
Copy link
Collaborator

@jasites jasites commented Mar 23, 2025

Description

Adds initial support for Vultr Container Registry

  • Registry plan info module (plan_container_registry_info)
  • Registry CRUD module (container_registry)
  • Registry info module (container_registry_info)
  • Registry repository RUD module (container_registry_repository)
    • Create is done via container push, hence the commented out section of the integration test
      • Advice/suggestions there are greatly appreciated
  • Registry repository info module (container_registry_repository_info)
  • Registry region info module (container_registry_region_info)

The work for managing repo users was started, but while that was being done, extensive work was done to expand the options available for managing users via the API. As this was getting rather cumbersome as it is, I wanted to get this in before starting on the user management portion.

Related Issues

Resolves #107

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

jasites added 2 commits March 23, 2025 12:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.24%. Comparing base (e193c3e) to head (57ad1c6).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
plugins/module_utils/vultr_v2.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #134       +/-   ##
===========================================
- Coverage   89.70%   59.24%   -30.47%     
===========================================
  Files          33        3       -30     
  Lines        1010      449      -561     
  Branches      171       73       -98     
===========================================
- Hits          906      266      -640     
- Misses         45      182      +137     
+ Partials       59        1       -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jasites jasites requested a review from resmo March 31, 2025 13:11
@jasites
Copy link
Collaborator Author

jasites commented Mar 31, 2025

@resmo I'm sure there are a few changes that are needed here, but I would need fresh eyes to spot them.

Also, the version used in the changes was made early in the process of building this out - would 1.14.0 be a more proper value to use?

@resmo
Copy link
Collaborator

resmo commented Mar 11, 2026

@jasites reviewing is on my list, sorry for the delay.

Copy link
Collaborator

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for the verison string to be 1.14.0 IMHO, didn't see any obvious mistakes. good job.

---
module: container_registry_info
short_description: Get information about the Vultr container registries
version_added: "1.15.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next release would be 1.14 right?

---
module: container_registry_region_info
short_description: Get information about the Vultr container registry regions
version_added: "1.15.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.14.0

@jasites
Copy link
Collaborator Author

jasites commented Mar 11, 2026

@resmo Thanks for the review! I want to make another pass at this, as significant enhancements and changes were made to the feature after I last worked on this.

I'm not sure when I will be able to get back to this (hopefully soon!), so I would recommend releasing 1.14.0 before waiting on this one...

@jasites jasites marked this pull request as draft March 11, 2026 12:58
@resmo
Copy link
Collaborator

resmo commented Mar 11, 2026

@jasites I am preparing a 1.4.0 release, would you mind if this is not in it?

@jasites
Copy link
Collaborator Author

jasites commented Mar 11, 2026

@jasites I am preparing a 1.4.0 release, would you mind if this is not in it?

Not at all - getting a new release out is more important.

@resmo resmo modified the milestones: v1.15, v1.9 Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] - Container Registry support

3 participants