add custom name support for osm maps and terrain#460
Draft
fredmarkus wants to merge 1 commit intovvoovv:releasefrom
Draft
add custom name support for osm maps and terrain#460fredmarkus wants to merge 1 commit intovvoovv:releasefrom
fredmarkus wants to merge 1 commit intovvoovv:releasefrom
Conversation
Signed-off-by: frederik <frederik.anilmarkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to provide custom names for terrain and osm map names. I have the following piece of code where I access map osm buildings and terrain data.
I have parallelized this to download and access multiple different objects at the same time. My problem is now that the current implementation assigns an index to the name of the terrain and the osm map and when downloading in parallel, multiple maps end up with the same name. With this PR I can run:
which allows me to set custom names for each map that is downloaded.
@vvoovv Using these modifications with the code above in Python works fine; however, when i try to run this in the GUI in Blender I get an error saying:
AttributeError: type object 'Renderer' has no attribute 'toJoin'I am not really sure why this is. Do you have an idea? I have marked the PR as a draft for now because of this.Note: I have only tested this on the base version of blosm so I don't know how it would perform on the premium version.