This repository was archived by the owner on Aug 15, 2025. It is now read-only.
XDP/Mellanox: T7223: Fixed interfaces initialization#37
Merged
sever-sever merged 1 commit intovyos-legacy:currentfrom Jun 18, 2025
Merged
XDP/Mellanox: T7223: Fixed interfaces initialization#37sever-sever merged 1 commit intovyos-legacy:currentfrom
sever-sever merged 1 commit intovyos-legacy:currentfrom
Conversation
For the XDP driver and Mellanox NIC, we create `defunct_*` interfaces to hide original interfaces from CLI, when they are replaced with VPP-enabled pairs. But sometimes IP addresses are not flushed from these `defunct_*` interfaces, which leads to broken routing afterward. This commit introduces an additional flush operation for `defunct_*` interfaces to ensure that they do not conflict with VPP interfaces.
sever-sever
approved these changes
Jun 18, 2025
Contributor
sever-sever
left a comment
There was a problem hiding this comment.
Flush addresses from renames defunct interface. This fixes connectivity issues due assignment addresses to defunct interface's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixed XDP and Mellanox interfaces initialization
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
For the XDP driver and Mellanox NIC, we create
defunct_*interfaces to hide original interfaces from CLI, when they are replaced with VPP-enabled pairs. But sometimes IP addresses are not flushed from thesedefunct_*interfaces, which leads to broken routing afterward.This commit introduces an additional flush operation for
defunct_*interfaces to ensure that they do not conflict with VPP interfaces.How to test
On a system with Mellanox card:
If you see an IP address on the interface, it was not flushed by ithe nterface initialization logic. This change fixes it.
Checklist: