T8046: traffic-engineering: support link-params

[hedrok]

Traffic-engineering: FRR link-params support

Add 'traffic-engineering' commands under 'protocols'.

set protocols traffic-engineering admin-group ADMINGROUP bit-position 1
set protocols traffic-engineering interface INTERFACE admin-group ADMINGROUP
set protocols traffic-engineering interface INTERFACE max-bandwidth 1280
set protocols traffic-engineering interface INTERFACE max-reservable-bandwidth 1280

Also add

set protocols isis traffic-engineering export

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T8046

Related PR(s)

• T8046: FRR: support no version of max-bw etc vyos-build#1082
• T8046: traffic-engineering vyos-documentation#1726

How to test / Smoketest result

I've added smoke test:

$ /usr/libexec/vyos/tests/smoke/cli/test_protocols_traffic-engineering.py
test_te_normal (__main__.TestProtocolsTrafficEngineering.test_te_normal) ... ok
test_te_verify (__main__.TestProtocolsTrafficEngineering.test_te_verify) ... ok

(works only after FRR fix in related PR)

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly (draft documentation PR:

[github-actions]

👍
No issues in PR Title / Commit Title

[l0crian1]

I think it may be more logical to have the traffic-engineering node fall under the mpls node like this:

set protocols mpls traffic-engineering admin-group ADMINGROUP bit-position 1
set protocols mpls traffic-engineering interface INTERFACE admin-group ADMINGROUP
set protocols mpls traffic-engineering interface INTERFACE max-bandwidth 1280
set protocols mpls traffic-engineering interface INTERFACE max-reservable-bandwidth 1280

This also falls more in line with the rest of industry.

[Copilot]

Pull request overview

This PR adds traffic-engineering (TE) link parameters support to VyOS, integrating FRR's link-params functionality. It enables configuration of admin groups, bandwidth limits, and TE metrics for interfaces, along with ISIS TE database export capabilities.

• Adds new protocols traffic-engineering configuration hierarchy with admin-group and interface parameters
• Integrates traffic-engineering into the FRR rendering framework
• Adds ISIS mpls-te export support to export TE database to other daemons

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/conf_mode/protocols_traffic_engineering.py	New configuration module handling TE validation and FRR integration
smoketest/scripts/cli/test_protocols_traffic-engineering.py	Comprehensive smoke tests covering normal operation and validation scenarios
python/vyos/frrender.py	Updates to include traffic_engineering in protocols list and config rendering
interface-definitions/protocols_traffic_engineering.xml.in	XML definition for TE CLI structure including admin-groups and interface parameters
interface-definitions/include/isis/protocol-common-config.xml.i	Adds ISIS TE export option
data/templates/frr/zebra.traffic_engineering.frr.j2	Jinja2 template generating FRR link-params configuration
data/templates/frr/isisd.frr.j2	Updates ISIS template to support mpls-te export command

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[hedrok]

I've fixed Copilot comments.

[fett0]

I think it may be more logical to have the traffic-engineering node fall under the mpls node like this:

set protocols mpls traffic-engineering admin-group ADMINGROUP bit-position 1
set protocols mpls traffic-engineering interface INTERFACE admin-group ADMINGROUP
set protocols mpls traffic-engineering interface INTERFACE max-bandwidth 1280
set protocols mpls traffic-engineering interface INTERFACE max-reservable-bandwidth 1280

This also falls more in line with the rest of industry.

@l0crian1 in the past, traffic engineering was tightly coupled with MPLS + RSVP. The syntax was quite similar to Junos. Nowadays, however, traffic engineering can be implemented through multiple technologies such as SRv6, BGP-TE, or SR-MPLS, so it’s better to keep it more technology-agnostic.

[fett0]

I've tested these command in my lab and works as expected.

[fett0]

@c-po @hedrok I see everything is ok or something is missing ? Could you review this code ?

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• CLI Smoketests VPP 👍 passed
• Config tests VPP 👍 passed
• TPM tests 👍 passed

[c-po]

New feature implementation looks good and tested via smoketests

[sever-sever]

Add the protocols traffic-engineering configuration option