Skip to content

T8144: fix and correct TPM and VPP test result reporting in smoke test workflow#4937

Merged
c-po merged 2 commits intovyos:currentfrom
kumvijaya:current
Jan 9, 2026
Merged

T8144: fix and correct TPM and VPP test result reporting in smoke test workflow#4937
c-po merged 2 commits intovyos:currentfrom
kumvijaya:current

Conversation

@kumvijaya
Copy link
Contributor

@kumvijaya kumvijaya commented Jan 8, 2026

Change summary

Problem

Failed TPM and VPP tests were incorrectly displayed as passed in PR comments due to checking job .result instead of test .outputs.exit_code.
Also Updated the workflow to report the status as-is without masking the failure.

Solution

Use .outputs.exit_code consistently for all test result checks:

  • exit_code == 'success' → '👍 passed'
  • exit_code == 'fail' → '❌ failed'
  • ⏭️ Undefined → '⏭️ skipped'

Files Changed

  • .github/workflows/package-smoketest.yml

Test/Validation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T8144

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@kumvijaya kumvijaya added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

👍
No issues in PR Title / Commit Title

Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the PR message however the workflow is successful and doesn't block merge:

Image

@kumvijaya
Copy link
Contributor Author

kumvijaya commented Jan 9, 2026

Fixes the PR message however the workflow is successful and doesn't block merge:

Image

Fixed.
Updated the workflow to report the status as-is without masking the failure.
Valdiated with below test PR
vyos#243

@kumvijaya kumvijaya requested a review from sarthurdev January 9, 2026 06:05
Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves smoketest workflow false-positive

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix failing smoketests false positives

@c-po c-po disabled auto-merge January 9, 2026 18:06
@c-po c-po merged commit 014ef8b into vyos:current Jan 9, 2026
7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current mirror-completed

Development

Successfully merging this pull request may close these issues.

4 participants