T8144: fix and correct TPM and VPP test result reporting in smoke test workflow#4937
Merged
c-po merged 2 commits intovyos:currentfrom Jan 9, 2026
Merged
T8144: fix and correct TPM and VPP test result reporting in smoke test workflow#4937c-po merged 2 commits intovyos:currentfrom
c-po merged 2 commits intovyos:currentfrom
Conversation
|
👍 |
sarthurdev
requested changes
Jan 8, 2026
Contributor
Author
Fixed. |
sarthurdev
approved these changes
Jan 9, 2026
Member
sarthurdev
left a comment
There was a problem hiding this comment.
Resolves smoketest workflow false-positive
c-po
approved these changes
Jan 9, 2026
Member
c-po
left a comment
There was a problem hiding this comment.
Fix failing smoketests false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Problem
Failed TPM and VPP tests were incorrectly displayed as passed in PR comments due to checking job
.resultinstead of test.outputs.exit_code.Also Updated the workflow to report the status as-is without masking the failure.
Solution
Use
.outputs.exit_codeconsistently for all test result checks:exit_code == 'success'→ '👍 passed'exit_code == 'fail'→ '❌ failed'Files Changed
.github/workflows/package-smoketest.ymlTest/Validation
Types of changes
Related Task(s)
https://vyos.dev/T8144Related PR(s)
How to test / Smoketest result
Checklist: