-
-
Notifications
You must be signed in to change notification settings - Fork 871
feat[venom]: support opt-level & fine grained venom pass disabling flags #4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| # Disable flags - default False means optimization is enabled | ||
| # These are used to override the defaults for the optimization level | ||
| disable_inlining: bool = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure there is anything to be done atm but i am concerned about long term drift between these fields and the relevant code in vyper_compile.py and vyper_json.py
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4757 +/- ##
==========================================
- Coverage 93.28% 93.20% -0.08%
==========================================
Files 137 142 +5
Lines 19623 19787 +164
Branches 3396 3427 +31
==========================================
+ Hits 18305 18443 +138
- Misses 894 912 +18
- Partials 424 432 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What I did
This PR adds new style optimisation level selection parameters and fine grained venom passes selection. Together, these changes give advanced users fine‑grained control over the Venom optimizer from both the CLI and JSON interfaces while preserving backward‑compatible behaviour for existing
--optimizeflags.How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture