Skip to content

Conversation

@harkal
Copy link
Collaborator

@harkal harkal commented Oct 1, 2025

What I did

This PR adds new style optimisation level selection parameters and fine grained venom passes selection. Together, these changes give advanced users fine‑grained control over the Venom optimizer from both the CLI and JSON interfaces while preserving backward‑compatible behaviour for existing --optimize flags.

How I did it

How to verify it

Commit message

adds new style optimisation level selection parameters and fine grained 
venom passes selection. Together, these changes give advanced users 
fine‑grained control over the Venom optimizer from both the CLI and 
JSON interfaces while preserving backward‑compatible behaviour for 
existing `--optimize` flags.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->


# Disable flags - default False means optimization is enabled
# These are used to override the defaults for the optimization level
disable_inlining: bool = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure there is anything to be done atm but i am concerned about long term drift between these fields and the relevant code in vyper_compile.py and vyper_json.py

@harkal harkal changed the title feat[venom]: venom command line parameters feat[venom]: venom command line optimisation and passes parameters Oct 29, 2025
@harkal harkal changed the title feat[venom]: venom command line optimisation and passes parameters feat[venom]: support opt-level & fine grained venom pass disabling flags Oct 29, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 86.25954% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.20%. Comparing base (3180c36) to head (01bfe35).

Files with missing lines Patch % Lines
vyper/cli/vyper_json.py 26.31% 11 Missing and 3 partials ⚠️
vyper/cli/vyper_compile.py 55.55% 9 Missing and 3 partials ⚠️
vyper/compiler/settings.py 95.69% 1 Missing and 3 partials ⚠️
vyper/cli/venom_main.py 0.00% 3 Missing ⚠️
vyper/venom/__init__.py 90.62% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4757      +/-   ##
==========================================
- Coverage   93.28%   93.20%   -0.08%     
==========================================
  Files         137      142       +5     
  Lines       19623    19787     +164     
  Branches     3396     3427      +31     
==========================================
+ Hits        18305    18443     +138     
- Misses        894      912      +18     
- Partials      424      432       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harkal harkal marked this pull request as ready for review November 27, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants