Skip to content

fix[lang]: fix exception for duplicate builtin imports #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix[lang]: fix exception for duplicate builtin imports #4764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be49c81
fix[parser]: Make duplicate built-in import exception consistent
Sporarum Oct 31, 2025
2011051
Fix mistaken multiple import error
Sporarum Nov 3, 2025
46be18d
Use self.graph for more reliability
Sporarum Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/functional/codegen/modules/test_stateless_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,16 @@ def test_reject_duplicate_imports(make_input_bundle):
compiler.compile_code(contract_source, input_bundle=input_bundle)


def test_reject_duplicate_builtin_imports(make_input_bundle):
contract_source = """
import math
import math as math2
"""
input_bundle = make_input_bundle({"contract.vy": contract_source})
with pytest.raises(DuplicateImport):
compiler.compile_code(contract_source, input_bundle=input_bundle)


def test_nested_module_access(get_contract, make_input_bundle):
lib1 = """
import lib2
Expand Down
6 changes: 3 additions & 3 deletions vyper/semantics/analysis/imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,6 @@ def _add_import(
def _load_import(
self, node: vy_ast.VyperNode, level: int, module_str: str, alias: str
) -> tuple[CompilerInput, Any]:
if _is_builtin(level, module_str):
return _load_builtin_import(level, module_str)

path = _import_to_path(level, module_str)

if path in self.graph.imported_modules:
Expand All @@ -197,6 +194,9 @@ def _load_import(

self.graph.imported_modules[path] = node

if _is_builtin(level, module_str):
return _load_builtin_import(level, module_str)

err = None

try:
Expand Down