feat[venom]: stack spilling to mem #4765
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
- Coverage 93.29% 93.24% -0.06%
==========================================
Files 140 141 +1
Lines 20265 20437 +172
Branches 3551 3584 +33
==========================================
+ Hits 18907 19056 +149
- Misses 911 925 +14
- Partials 447 456 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…feat/simple_mem_spill
| if dup_idx < 1: | ||
| from vyper.exceptions import StackTooDeep | ||
|
|
||
| raise StackTooDeep(f"Unsupported dup depth {dup_idx}") |
Member
There was a problem hiding this comment.
this is like a DUP0, right? seems like the wrong exception in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture