Skip to content

Conversation

@Sporarum
Copy link
Contributor

What I did

Fix #4728

How I did it

How to verify it

Commit message

this commits adds some logic to handle typechecking of nested subscripts
in the presence of tuple types. it assumes the only valid indices for
tuples are constant integers, this is guaranteed by the parser.

it also adds a new test that checks these kinds of nested subscripts.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (31122dc) to head (df4b8d5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4776   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         137      137           
  Lines       19465    19475   +10     
  Branches     3364     3366    +2     
=======================================
+ Hits        18161    18171   +10     
  Misses        884      884           
  Partials      420      420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compiler crash during type checking in visit_Subscript for tuples

2 participants