Add GraphPosition parameter to onConnectEnd callback (#22)

Author: afpatmin

packages/vyuh_node_flow/lib/graph/api/connection_api.dart

@@ -1103,8 +1103,13 @@ extension ConnectionApi<T> on NodeFlowController<T> {
     required String targetPortId,
   }) {
     final temp = interaction.temporaryConnection.value;
+
+    final eventPosition = interaction.pointerPosition == null
+        ? GraphPosition.zero
+        : viewport.toGraph(interaction.pointerPosition!);
+
     if (temp == null) {
-      events.connection?.onConnectEnd?.call(null, null);
+      events.connection?.onConnectEnd?.call(null, null, eventPosition);
       return null;
     }
 
@@ -1213,10 +1218,16 @@ extension ConnectionApi<T> on NodeFlowController<T> {
 
     // Fire connection end event with the target node and port that the user dropped on
     final droppedOnNode = _nodes[targetNodeId];
+
     final droppedOnPort = droppedOnNode?.allPorts
         .where((p) => p.id == targetPortId)
         .firstOrNull;
-    events.connection?.onConnectEnd?.call(droppedOnNode, droppedOnPort);
+
+    events.connection?.onConnectEnd?.call(
+      droppedOnNode,
+      droppedOnPort,
+      eventPosition,
+    );
 
     return createdConnection;
   }
@@ -1228,6 +1239,7 @@ extension ConnectionApi<T> on NodeFlowController<T> {
   void cancelConnectionDrag() {
     // Reset highlighted port before canceling
     final temp = interaction.temporaryConnection.value;
+
     if (temp != null &&
         temp.targetNodeId != null &&
         temp.targetPortId != null) {
@@ -1245,7 +1257,10 @@ extension ConnectionApi<T> on NodeFlowController<T> {
     interaction.cancelConnection();
 
     // Note: Canvas unlocking is now handled by DragSession
-
-    events.connection?.onConnectEnd?.call(null, null);
+    events.connection?.onConnectEnd?.call(
+      null,
+      null,
+      temp == null ? GraphPosition.zero : GraphPosition(temp.currentPoint),
+    );
   }
 }

packages/vyuh_node_flow/lib/graph/node_flow_events.dart

@@ -282,7 +282,13 @@ class ConnectionEvents<T> {
   ///
   /// If [targetNode] and [targetPort] are non-null, a connection was successfully
   /// created to that target. If both are null, the connection was cancelled.
-  final void Function(Node<T>? targetNode, Port? targetPort)? onConnectEnd;
+  /// [position] provides the graph coordinates where the event occurred.
+  final void Function(
+    Node<T>? targetNode,
+    Port? targetPort,
+    GraphPosition position,
+  )?
+  onConnectEnd;
 
   /// Validation callback before starting a connection from a port
   /// Return ConnectionValidationResult with allowed: false to prevent connection start
@@ -307,7 +313,12 @@ class ConnectionEvents<T> {
     void Function(Connection connection, ScreenPosition screenPosition)?
     onContextMenu,
     void Function(Node<T> sourceNode, Port sourcePort)? onConnectStart,
-    void Function(Node<T>? targetNode, Port? targetPort)? onConnectEnd,
+    void Function(
+      Node<T>? targetNode,
+      Port? targetPort,
+      GraphPosition position,
+    )?
+    onConnectEnd,
     ConnectionValidationResult Function(ConnectionStartContext<T> context)?
     onBeforeStart,
     ConnectionValidationResult Function(ConnectionCompleteContext<T> context)?

packages/vyuh_node_flow/test/behavior/connections/connection_creation_test.dart

@@ -592,7 +592,7 @@ void main() {
       controller.internalUpdateEvents(
         NodeFlowEvents<String>(
           connection: ConnectionEvents(
-            onConnectEnd: (node, port) {
+            onConnectEnd: (node, port, _) {
               endTargetNode = node;
               endTargetPort = port;
             },
@@ -685,7 +685,7 @@ void main() {
       controller.internalUpdateEvents(
         NodeFlowEvents<String>(
           connection: ConnectionEvents(
-            onConnectEnd: (node, port) {
+            onConnectEnd: (node, port, _) {
               callbackFired = true;
               endTargetNode = node;
               endTargetPort = port;