fix: disable Electron sandbox to avoid Ubuntu clone3 crash#34
Open
voidnullvalue wants to merge 2 commits intow00000dy:masterfrom
Open
fix: disable Electron sandbox to avoid Ubuntu clone3 crash#34voidnullvalue wants to merge 2 commits intow00000dy:masterfrom
voidnullvalue wants to merge 2 commits intow00000dy:masterfrom
Conversation
Owner
|
Thanks for the PR! While this fixes the clone3 crash, I am concerned about the security implications of completely disabling the sandbox. Have you tried simply updating the Electron version instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu LTS (22.04+) prevents Electron's sandbox from launching due to seccomp-blocked
clone3()syscall, causing renderer crashes.This patch:
sandbox: trueinBrowserWindow(main window only)package.jsonto launch with--no-sandboxvia CLITested on Ubuntu — app launches and device panels now work without crashing.
Note:
createWorker()still uses sandboxed config; may need follow-up.