Merged
Conversation
LangTag's Ord is buggy: it is not case-insensitive
Tpt
approved these changes
Nov 28, 2025
pchampin
added a commit
that referenced
this pull request
Nov 28, 2025
NB: cargo clippy is still unhappy, but this is handled in #12
Tpt
reviewed
Nov 28, 2025
the previous implementation relied on str::to_ascii_lowercase, which performed an allocation. We now avoid by implementing ascii-case-insensitive comparison directly on the str.
pchampin
added a commit
that referenced
this pull request
Apr 1, 2026
NB: cargo clippy is still unhappy, but this is handled in #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a bug in
LangString:PartialOrdwas case insensitive, butOrdwas not(thanks to
clippyfor spotting that!)this also fixes a number of linting issues