Skip to content

[WIP] WIP Address feedback on prepare credential requests algorithm #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 1 commit into from
Closed

[WIP] WIP Address feedback on prepare credential requests algorithm #459

Copilot wants to merge 1 commit into from

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026 •
edited
Loading

  • Understand the AbortSignal handling issue identified by reviewer
  • Remove assertion that signal is not aborted
  • Add check for pre-aborted signals to complete request immediately
  • Modify abort algorithm to check for active promise instead of just "requesting" state
  • Validate changes work correctly

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Feb 3, 2026
Open
9 tasks
Copilot AI requested a review from marcoscaceres February 3, 2026 10:56
Copilot stopped work on behalf of marcoscaceres due to an error February 3, 2026 10:56
The session was cancelled by the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres Awaiting requested review from marcoscaceres

Assignees

@marcoscaceres marcoscaceres

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcoscaceres