Skip to content

Commit 5863d21

Browse files
authored
Merge pull request #76 from saschanaz/clonewithoutids
Trim ids when cloning descriptions
2 parents ccacfbc + a3bca83 commit 5863d21

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

script/aria.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
var roleInfo = {};
1414

1515
function ariaAttributeReferences() {
16-
{
1716
var propList = {};
1817
var globalSP = [];
1918

@@ -46,7 +45,7 @@ function ariaAttributeReferences() {
4645
'</span>';
4746
sp.setAttribute('aria-describedby', 'desc-' + title);
4847
var dRef = item.nextElementSibling;
49-
var desc = dRef.firstElementChild.innerHTML;
48+
var desc = cloneWithoutIds(dRef.firstElementChild).innerHTML;
5049
dRef.id = 'desc-' + title;
5150
dRef.setAttribute('role', 'definition');
5251
var heading = document.createElement('h4');
@@ -255,7 +254,7 @@ function ariaAttributeReferences() {
255254
// sp.id = title;
256255
sp.setAttribute('aria-describedby', 'desc-' + title);
257256
var dRef = item.nextElementSibling;
258-
var desc = dRef.firstElementChild.innerHTML;
257+
var desc = cloneWithoutIds(dRef.firstElementChild).innerHTML;
259258
dRef.id = 'desc-' + title;
260259
dRef.setAttribute('role', 'definition');
261260
container.replaceChild(sp, item);
@@ -745,7 +744,14 @@ function ariaAttributeReferences() {
745744
});
746745

747746
updateReferences(document);
748-
}
747+
748+
function cloneWithoutIds(node) {
749+
const clone = node.cloneNode(true);
750+
for (const elementWithId of clone.querySelectorAll("[id]")) {
751+
elementWithId.removeAttribute("id");
752+
}
753+
return clone;
754+
}
749755
}
750756

751757
require(['core/pubsubhub'], function (respecEvents) {

0 commit comments

Comments
 (0)