Skip to content

Conversation

umairrkhan009
Copy link
Contributor

@umairrkhan009 umairrkhan009 commented Jul 2, 2025

This PR fixes inconsistent casing of "JavaScript" across the project.

Changes include:

  • Replacing all instances of "Javascript" with "JavaScript" in content/ and content-templates/
  • Updating related comments for consistency
  • Resolving the issue that caused the coverage report to fail in the previous PR

(description copied from #3317)


WAI Preview Link (Last built on Wed, 06 Aug 2025 16:21:39 GMT).

@mcking65 mcking65 changed the title Rename Javascript to JavaScript All Pages: Change 'Javascript' to 'JavaScript' Jul 8, 2025
@mcking65
Copy link
Contributor

mcking65 commented Jul 8, 2025

@howard-e

Could you please investigate reason for failure of Check examples/index.html / coverage (pull_request)?

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @umairrkhan009, thanks for the submission!

Still seeing 8 instances of Javascript with 's' as lowercase when I search the project. 2 of them being required by coverage-report.template, which is causing the build failure.

@a11ydoer a11ydoer self-assigned this Jul 8, 2025
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 3306: Rename Javascript to JavaScript.

The full IRC log of that discussion <jugglinmike> Topic: PR 3306: Rename Javascript to JavaScript
<jugglinmike> github: https://github.com//pull/3306
<jugglinmike> Matt_King: This was spun up as a result of a comment in a previous pull request
<jugglinmike> Matt_King: A contributor made a fix for this almost immediately! I included a link in the agenda
<jugglinmike> howard-e: I checked out the error in CI, and I replied to it on the pull request
<jugglinmike> howard-e: The template doesn't have the updated case, but they modified the affected file directly
<jugglinmike> howard-e: I was giving the contributor a chance to update
<jugglinmike> Matt_King: Got it
<jugglinmike> Matt_King: I would like to have someone assigned as a reviewer so that when the change lands, someone can step in and finalize
<jugglinmike> Jem: I volunteer. I assigned to myself
<jugglinmike> Matt_King: Thank you!

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 3306: Rename Javascript to JavaScript.

The full IRC log of that discussion <jugglinmike> Topic: PR 3306: Rename Javascript to JavaScript
<jugglinmike> github: https://github.com//pull/3306
<jugglinmike> Matt_King: We have a review of this--it's strictly editorial
<jugglinmike> Matt_King: The person who originally submitted this, howard-e reviewed and found some occurrences of the string which were not covered
<jugglinmike> howard-e: Yes, they were outside the content tree. They were in templates
<jugglinmike> Matt_King: We don't have a response from the person who originally created the pull request
<jugglinmike> Matt_King: I think that, because we don't have a publication date set, yet, we can wait a couple weeks
<jugglinmike> Matt_King: We can mention the person on this thread to bump their awareness
<jugglinmike> Matt_King: I think it's okay to let this sit
<jugglinmike> Matt_King: If we don't get a response after that, we can merge it to a feature branch, push a few more changes, and then merge it
<jugglinmike> howard-e: That seems fine to me, as well. I can wait until the end of the week and ping the author again
<jugglinmike> howard-e: the coverage report is failing because the contributor only updated the target file that the template would update, but not the template itself
<jugglinmike> Matt_King: So as soon as the source is updated (in the content/shared/template directory), then that will be good
<jugglinmike> Matt_King: And that's not a WAI template, that's our own template
<jugglinmike> howard-e: That's right
<jugglinmike> Jem: And eventually, are we going to move those templates into WAI?
<jugglinmike> Matt_King: No, because those templates are not design templates--they're content templates
<jugglinmike> Jem: Got it

@umairrkhan009
Copy link
Contributor Author

Thanks for the review and discussion! I saw the IRC notes—apologies for missing the template files. I'll make the necessary updates in the content/shared/template/ directory and push the changes shortly. Let me know if there's anything else I should look at.

@a11ydoer
Copy link
Contributor

We appreciate you raising the issue and the updating the PR, @umairrkhan009

@nschonni
Copy link
Contributor

Might make sense to add the preference to the cSpell config https://cspell.org/docs/forbidden-words

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 3306: Rename Javascript to JavaScript.

The full IRC log of that discussion <jugglinmike> Topic: PR 3306: Rename Javascript to JavaScript
<jugglinmike> github: https://github.com//pull/3306
<jugglinmike> Matt_King: We requested the contributor to make some changes, and they told us that they made the changes
<jugglinmike> Matt_King: howard-e have you re-reviewed this since then?
<jugglinmike> howard-e: Not yet, no. I'm seeing that there is a duplicate pull request. Pull request #3317
<jugglinmike> https://github.com//pull/3317
<jugglinmike> howard-e: It's authored by the same contributor
<jugglinmike> howard-e: It seems to be identical
<jugglinmike> howard-e: They pushed the original plus the fix into this new pull request
<jugglinmike> Matt_King: If possible, I'd like to get the fix into the original pull request so that the history is easier to follow
<jugglinmike> Matt_King: There's a nitpick about cspell. It's a one-line change that isn't directly related, so I'd love it if someone can do it in a separate patch
<jugglinmike> arigilmore: I can do that
<jugglinmike> Matt_King: Thank you!

@howard-e
Copy link
Contributor

howard-e commented Aug 6, 2025

Might make sense to add the preference to the cSpell config https://cspell.org/docs/forbidden-words

Great thought @nschonni ! It was discussed and being done in a separate PR, #3329

@howard-e
Copy link
Contributor

howard-e commented Aug 6, 2025

I've reverted the change to skipto.js here. While there are 4 remaining comments read "Javascript", it seems some unexpected formatting happened there.

I would also prefer if this is a change that happens upstream for skipto.js which @jongund may have some opinion on. That change could be included in #3213 instead.

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umairrkhan009 thanks for taking this on! Changes are good to me and the feedback has been addressed.

@a11ydoer I'll leave this to you to finalize and merge.

@mcking65 mcking65 merged commit 8b05538 into w3c:main Aug 12, 2025
12 checks passed
@mcking65 mcking65 added this to the Next publication milestone Aug 12, 2025
@mcking65
Copy link
Contributor

Thank you @umairrkhan009 for this contribution to the APG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Javascript" with lowercase S to "JavaScript" with uppercase S for consistency
6 participants