-
Notifications
You must be signed in to change notification settings - Fork 138
Issue899 accname from heading #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ec71e9c
initial proposal for accessible name from heading
jongund f73203e
added dialog and alertdialog
jongund 7e1aa61
Merge branch 'master' into issue899-accname-from-heading
jongund 8547f5e
added nesting restrictions for naming and added region as a potential…
jongund 5cc0b84
updated defintion of region role authoring practices
jongund ddf5ee3
updated defintion of region role authoring practices
jongund dfe9ff9
updated defintion of region role authoring practices
jongund 75c7b5d
updated definition of name from heading definition
jongund 1c5da0e
removed main element from list and restricted heading ro be first child
jongund f5206e6
made the heading naming technique adpatable to requirements of naming…
jongund aea75f6
added restructoin to only naming nearest ancestor
jongund 487fb4f
clarified first descentant element with role heading using depth firs…
jongund 5ceb223
Apply suggestions from code review
cookiecrook 10b90f5
testing whitespace cruft correction in the GH interface
cookiecrook cd7cc12
m. test whitespace diff correction
cookiecrook c03c01d
Apply suggestions from code review
cookiecrook 6d88243
m. missed one errant whitespace diff
cookiecrook 932765b
Apply suggestions from code review
cookiecrook 14c1f8e
pulling inessentials out of the diff before re-requesting reviews
cookiecrook fca0262
extra whitespace included in new line
cookiecrook 0b6697b
deleting excess
cookiecrook 455274f
m. ed nit
cookiecrook 6fd2836
m. ed
cookiecrook c852c8f
remove namefrom: encapsulation
cookiecrook 51af51b
remove namefrom: legend
cookiecrook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.