[accname PR 229] Add nameFrom: heading to AccName text alt algorithm
#2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
pkra
changed the title
nameFrom: heading to AccName text alt algorithm nameFrom: heading to AccName text alt algorithm
Member
Author
|
Now pointing to main. |
Member
|
@cookiecrook should this change be merged into #1860? |
Contributor
|
I'm happy to incorporate if you'd like. I recall I started the other PR before the monorepo was a thing. I just want to get it merged. |
cookiecrook
reviewed
Apr 18, 2025
| </li> | ||
| <li id="comp_name_from_heading"> | ||
| <em>Name From Heading:</em> Otherwise, if the <code>current node</code> has a role that supports <a href="https://w3c.github.io/aria/#namefromheading">nameFrom: heading</a>, return | ||
| the text alternative of the first descendant <a>element</a> node matching the role of <code>heading</code> in an <em>iterative deepening depth-first search.</em> |
Contributor
There was a problem hiding this comment.
This changed later from IDDFS to DFS.
Suggested change
| the text alternative of the first descendant <a>element</a> node matching the role of <code>heading</code> in an <em>iterative deepening depth-first search.</em> | |
| the text alternative of the first descendant <a>element</a> node matching the role of <code>heading</code> in an <em>depth-first search.</em> |
Contributor
There was a problem hiding this comment.
Member
|
I had offered to try and merge the related prs together (as there’s an html aam one too) but I haven’t had the time as I had hoped. |
jnurthen
added
the
waiting for implementations
spectranaut
moved this from All PRS
to Waiting For Implementation
in ARIA Normative PR Tracking
Contributor
|
@cookiecrook can we close this too in favor of #2650? |
Contributor
|
Yes. This diff is already part of the new PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from w3c/accname#229
229 was approved by @MelSumner and @accdc
Preview | Diff