-
Notifications
You must be signed in to change notification settings - Fork 138
[html-aam PR 529] Addition: Name from heading #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
closes #457 Related to the following: - #1860 - w3c/accname#229 (this needs to be merged so the new links to 'accName: name from heading' will work
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
per @cookiecrook review, changing a couple more instances where 'accessible name' should be used instead of 'subtree'
|
Re-assigning reviewers @cookiecrook @spectranaut for this migrated html-aam PR. |
spectranaut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good to me. @cookiecrook @scottaohara I wonder if these changes should be moved to the main PR: #1860 -- since it is related to the implementation and should land at the same time?
That is the goal of the mono repo, less PRs when there are dependent changes across specs.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| </ol> | ||
| </section> | ||
| <section> | ||
| <h4>`dialog` Element Accessible Name Computation</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this PR need to be modified once the namefrom:heading PR lands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More directly, I think this effectively duplicates what will be in the AccName computation...
- labelledby, then label, then namefrom:heading, then fall back to host-language tooltip...
|
@spectranaut wrote:
No strong preference... @scottaohara you can either keep this one here or merge your diffs (caveat change requests) into the |
This commit supersedes PR #2215
|
closing this PR as the necessary changes specific to name from heading have been moved into #2650 |
Moved from w3c/html-aam#529
Adds name from heading computation steps for
<article>and<dialog>