Skip to content

Conversation

@pkra
Copy link
Member

@pkra pkra commented May 23, 2024

Moved from w3c/html-aam#529

Adds name from heading computation steps for <article> and <dialog>

scottaohara and others added 5 commits February 6, 2024 11:28
closes #457

Related to the following:
- #1860
- w3c/accname#229 (this needs to be merged so the new links to 'accName: name from heading' will work
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
per @cookiecrook review, changing a couple more instances where 'accessible name' should be used instead of 'subtree'
@pkra pkra changed the base branch from monorepo_history--html-aam to main June 12, 2024 19:29
@pkra pkra changed the title [Monorepo] [html-aam PR 529] Addition: Name from heading [html-aam PR 529] Addition: Name from heading Jun 12, 2024
@rahimabdi
Copy link
Contributor

Re-assigning reviewers @cookiecrook @spectranaut for this migrated html-aam PR.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me. @cookiecrook @scottaohara I wonder if these changes should be moved to the main PR: #1860 -- since it is related to the implementation and should land at the same time?

That is the goal of the mono repo, less PRs when there are dependent changes across specs.

@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 01034a7
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/68e7b7b02da35200077b2fd6
😎 Deploy Preview https://deploy-preview-2215--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

</ol>
</section>
<section>
<h4>`dialog` Element Accessible Name Computation</h4>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this PR need to be modified once the namefrom:heading PR lands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More directly, I think this effectively duplicates what will be in the AccName computation...

  • labelledby, then label, then namefrom:heading, then fall back to host-language tooltip...

@cookiecrook
Copy link
Contributor

@spectranaut wrote:

I wonder if these changes should be moved to the main PR: #1860 [now #2650] -- since it is related to the implementation and should land at the same time? That is the goal of the mono repo, less PRs when there are dependent changes across specs.

No strong preference... @scottaohara you can either keep this one here or merge your diffs (caveat change requests) into the namefrom-heading-2025 branch for #2650.

scottaohara added a commit that referenced this pull request Oct 21, 2025
@scottaohara
Copy link
Member

closing this PR as the necessary changes specific to name from heading have been moved into #2650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting For Implementation

Development

Successfully merging this pull request may close these issues.

6 participants