-
Notifications
You must be signed in to change notification settings - Fork 138
[Core-AAM] Update role=scrollbar AXAPI platform mappings #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahimabdi
wants to merge
2
commits into
main
Choose a base branch
from
rahim/axapi-mapping-for-scrollview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13681,9 +13681,15 @@ <h2>Definitions of States and Properties (all aria-* attributes)</h2> | |
| <sdef>aria-expanded</sdef> | ||
| <div class="state-description"> | ||
| <p><a>Indicates</a> whether a related element is expanded (shown) or collapsed (hidden).</p> | ||
| <p>The <sref>aria-expanded</sref> attribute is applied to a focusable, interactive element that toggles visibility of content of a different element. If the element with <sref>aria-expanded</sref> is also a <rref>treeitem</rref> in a <rref>tree</rref> or a <rref>row</rref> in a <rref>treegrid</rref>, then it SHOULD also be the <a>accessibility parent</a> of the content it expands and collapses. Otherwise, the element with <sref>aria-expanded</sref> SHOULD NOT be the <a>accessibility parent</a> of the content that is expanding or collapsing. Rather, identify that relationship between the interactive element and the element being controlled using <pref>aria-controls</pref>.</p> | ||
| <p> | ||
| The <sref>aria-expanded</sref> attribute is applied to a focusable, interactive element that toggles visibility of content of a different element. If the element with | ||
| <sref>aria-expanded</sref> is also a <rref>treeitem</rref> in a <rref>tree</rref> or a <rref>row</rref> in a <rref>treegrid</rref>, then it SHOULD also be the | ||
| <a>accessibility parent</a> of the content it expands and collapses. Otherwise, the element with <sref>aria-expanded</sref> SHOULD NOT be the <a>accessibility parent</a> of the content | ||
| that is expanding or collapsing. Rather, identify that relationship between the interactive element and the element being controlled using <pref>aria-controls</pref>. | ||
| </p> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this looks like formatting changes that snuck in because of prettier... :/ maybe try rebasing? |
||
| <p>For example, <sref>aria-expanded</sref> is applied to a parent <rref>treeitem</rref> to indicate whether its child branch of the tree is shown.</p> | ||
| <pre class="example highlight"><ul role="tree"> | ||
| <pre class="example highlight"> | ||
| <ul role="tree"> | ||
| <li role="treeitem" aria-expanded="false" aria-selected="false"> | ||
| <span>Fruits</span> | ||
| <ul role="group" hidden> | ||
|
|
@@ -13692,12 +13698,15 @@ <h2>Definitions of States and Properties (all aria-* attributes)</h2> | |
| <li role="treeitem" aria-selected="false">Yuzu</li> | ||
| </ul> | ||
| </li> | ||
| </ul></pre> | ||
| </ul></pre | ||
| > | ||
| <p>Similarly, it can be applied to a <rref>button</rref> to control the visibility of another element and its content on the current page.</p> | ||
| <pre class="example highlight"><button type="button" aria-controls="mangosteen" aria-expanded="false">Mangosteen</button> | ||
| <pre class="example highlight"> | ||
| <button type="button" aria-controls="mangosteen" aria-expanded="false">Mangosteen</button> | ||
| <div id="mangosteen" hidden> | ||
| An edible fruit native to tropical lands surrounding the Indian Ocean. | ||
| </div></pre> | ||
| </div></pre | ||
| > | ||
| </div> | ||
| <table class="def"> | ||
| <caption> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rahimabdi, with my read of the attribute's documentation... this property is not exposed scrollbar element, but on the element that the scroll bar controls? If so then these two properties don't belong here, because they aren't properties surfaced on the scrollbar.
Or maybe we could still say something about these properties here... something like: