on the contributors page, only lists the closed PRs and the last date#281
Merged
on the contributors page, only lists the closed PRs and the last date#281
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
server.js:695
- The use of the spread operator in 'new Date(...doc.lastUpdated)' assumes that doc.lastUpdated is iterable. If it is a single date value or string, consider using 'new Date(doc.lastUpdated)' to avoid runtime errors.
nonSubstantiveContributors[contributor].prs.push({num: doc.num, lastUpdated: new Date(...doc.lastUpdated).toDateString()});
server.js:702
- Similarly, the use of 'new Date(...doc.lastUpdated)' may be problematic if doc.lastUpdated is not an iterable. Using 'new Date(doc.lastUpdated)' might be more appropriate if doc.lastUpdated is a direct date string or value.
substantiveContributors[affiliationId].prs.push({num: doc.num, lastUpdated: new Date(...doc.lastUpdated).toDateString()});
dontcallmedom
approved these changes
Apr 28, 2025
Member
dontcallmedom
left a comment
There was a problem hiding this comment.
LGTM, but yes, I think we should keep track of and distinguish PRs that are merged vs closed (which is part of what #270 is about from my perspective)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #270