Skip to content

on the contributors page, only lists the closed PRs and the last date#281

Merged
deniak merged 3 commits intomasterfrom
repo-contributors-closed-date
Apr 29, 2025
Merged

on the contributors page, only lists the closed PRs and the last date#281
deniak merged 3 commits intomasterfrom
repo-contributors-closed-date

Conversation

@deniak
Copy link
Member

@deniak deniak commented Apr 14, 2025

Fix #270

@deniak deniak requested review from Copilot and dontcallmedom April 14, 2025 14:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

server.js:695

  • The use of the spread operator in 'new Date(...doc.lastUpdated)' assumes that doc.lastUpdated is iterable. If it is a single date value or string, consider using 'new Date(doc.lastUpdated)' to avoid runtime errors.
nonSubstantiveContributors[contributor].prs.push({num: doc.num, lastUpdated: new Date(...doc.lastUpdated).toDateString()});

server.js:702

  • Similarly, the use of 'new Date(...doc.lastUpdated)' may be problematic if doc.lastUpdated is not an iterable. Using 'new Date(doc.lastUpdated)' might be more appropriate if doc.lastUpdated is a direct date string or value.
substantiveContributors[affiliationId].prs.push({num: doc.num, lastUpdated: new Date(...doc.lastUpdated).toDateString()});

Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but yes, I think we should keep track of and distinguish PRs that are merged vs closed (which is part of what #270 is about from my perspective)

@deniak deniak merged commit d95ef71 into master Apr 29, 2025
2 checks passed
@deniak deniak deleted the repo-contributors-closed-date branch April 29, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter merged PRs on the contributors list

3 participants