Conversation
❌ Deploy Preview for clreq failed.
|
|
We also need to make dark mode versions for at least some of the images in the document. |
dark.css
Outdated
| #langSwitch button:lang(zh-hans) { | ||
| background-color: #005a9c; | ||
| } | ||
|
|
||
| #langSwitch button:lang(zh-hant) { | ||
| background-color: #0171c4; | ||
| } |
There was a problem hiding this comment.
These two colours are too close to each other. The different colours here are to allow people who do not understand Chinese to better distinguish Traditional and Simplified Chinese.
In addition, we need to update
Lines 183 to 188 in 7d51569
dark.css
Outdated
| } | ||
|
|
||
| .checkme { | ||
| background-color: #627262; |
There was a problem hiding this comment.
Personally, I would prefer a darker background, but not strong enough to object this.
index.html
Outdated
|
|
||
| <figure id="fig-loose-setting"> | ||
| <span style="text-align:center;"><img src="images/en/increased-inter-character-spacing.svg" alt="Examples of loose setting in horizontal writing mode." width="600" height="209"></span> | ||
| <span style="text-align:center;"><img class="invert-on-dark-mode" src="images/en/increased-inter-character-spacing.svg" alt="Examples of loose setting in horizontal writing mode." width="600" height="209"></span> |
There was a problem hiding this comment.
Our theme colour, green, will be missing if we invert the images. We'll discuss if we need to fix this in the teleconference.
|
Thanks for updating the PR! I made some comments. IMHO we can consider using CSS custom properties (like https://github.com/w3c/bp-i18n-specdev/pull/130/files ), so that when updating the colour, it is easier to remember that we also have a dark theme that needs to be updated. |
|
And we also need to update Line 327 in 7d51569 |
|
Per https://github.com/w3c/respec/pull/4700 , please remove <meta name="color-scheme" content="light dark"> |
|
There are still some problems with manually switching the colour theme. Let’s wait until https://github.com/w3c/respec/issues/4687 is resolved. |
|
per https://www.w3.org/International/i18n-activity/guidelines/editing#darkmode , we should use |

Fixes #611
Preview | Diff